filesystem: guided creates logicals if in_extended #1379
Conversation
| else: | ||
| # find what's left of the gap after adding boot | ||
| gap = gaps.within(disk, gap) | ||
| if gap is None: | ||
| raise Exception('failed to locate gap after adding boot') | ||
| return disk, gap | ||
| return gap |
There was a problem hiding this comment.
I wonder if this method still has the best name given the change in its signature here?
There was a problem hiding this comment.
I have a refactor branch that I want to do soon (next?). I have a slightly better name setup_gap_for_guided, but really the refactor branch should sort that out.
| flag = None | ||
| if gap.in_extended: | ||
| flag = 'logical' | ||
| return self.create_partition( |
There was a problem hiding this comment.
Aiee duelling abstractions I guess -- but maybe create_partition should handle (or at least check?) this logic?
There was a problem hiding this comment.
That would let you delete this method, which has a funny name. This little corner doesn't feel completely thought out?
There was a problem hiding this comment.
OK, I will move this to create_partition(). I actually started with that.
The lower-level add_partition() is a bit too clever for my liking (rounds up sizes!), so maybe we start to make create_partition() be the smart one.
dbungert
force-pushed
the
guided-create-logical
branch
from
586e421
to
60378fc
Compare
| @@ -78,8 +78,11 @@ def delete_filesystem(self, fs): | |||
| delete_format = delete_filesystem | |||
|
|
|||
| def create_partition(self, device, gap, spec, **kw): | |||
| flag = kw.pop('flag', None) | |||
| if gap.in_extended: | |||
| flag = 'logical' | |||
There was a problem hiding this comment.
Should this yell at you if the passed flag is not None or logical?
There was a problem hiding this comment.
Yes, I think yelling about invalid flags is sensible.
But this could be any valid curtin partition flag I think?
No description provided.