Fixing disk path matcher to really match agains DEVPATH of udev #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I don't really thing we should change the behaviour like that, despite the documentation being, as you point out, wrong. It would be better to evaluate the glob under ['match']['path'] against the actual filesystem and then check we found a block device I think... |
|
That is a bit behind my horizon. In that case the documentation would need to be adapted as well. |
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
Mar 1, 2023
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
Mar 1, 2023
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
Mar 5, 2023
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
Mar 5, 2023
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
May 16, 2023
rmounce
added a commit
to acres-com-au/subiquity
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the autoinstall-reference says:
The code is not looking for DEVPATH, like the other matchers are looking for their udev value. Instead it takes the path in probe_data. In my example that path is just "/dev/sda", but that does not help me matching exactly the disk i want. DEVPATH holds the real device path ("/device/pci..."), where i can better match what i want. Also the code should fit to the documentation.
This will not fix https://bugs.launchpad.net/subiquity/+bug/1952228, but is somewhat related to that.