errorreport: all recent syslog #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some outputs only appear in the journal.
ogayot
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks!
Seems like the command used will be ["journalctl", "--system", "--quiet", "-b", "-a"].
https://github.com/canonical/apport/blob/22f4525839cd5f164bc0635148d2e1cade815566/apport/hookutils.py#L635
If so, we might miss out on the commands run using systemd-run --user (because of the --system option); which is a bit of a shame but this is already a great step.
|
I've opened a PR on apport: canonical/apport#150 The proposal is to introduce: recent_syslog(re.compile("."), journald_system_only=False)but this is not something we can rely on yet. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some outputs only appear in the journal.