server: fix when cloud-config has no default user #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhudson
approved these changes
Jun 7, 2023
ogayot
approved these changes
Jun 7, 2023
dbungert
force-pushed
the
default-user-none
branch
from
f715b22
to
6c8da50
Compare
If a cloud-config is sent that adjusts the users but creates no default user, Subiquity crashes with a exception while mishandling the None. cloudinit.distros.ug_util.extract_default is documented as returning None in the event that the default user cannot be found. Example bad cloud-config: ```yaml users: - name: ubuntu-server ```
dbungert
force-pushed
the
default-user-none
branch
from
6c8da50
to
5bd9a4f
Compare
blackboxsw
reviewed
Jun 29, 2023
| if username is None: | ||
| # extract_default can return None, if there is no default user | ||
| self.installer_user_passwd_kind = PasswordKind.NONE | ||
| elif self._user_has_password(username): |
There was a problem hiding this comment.
Makes sense, so the error we are avoiding here is _user_has_password fails with something like:
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
There was a problem hiding this comment.
Yes, that's exactly what happens
blackboxsw
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cloud-config is sent that adjusts the users but creates no default user, Subiquity crashes with a exception while mishandling the None.
cloudinit.distros.ug_util.extract_default is documented as returning None in the event that the default user cannot be found.
Example bad from the Subiquity point of view but otherwise valid cloud-config: