Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: use skip_install to speed up black/isort #1744

Merged
merged 1 commit into from Jul 26, 2023

Conversation

dbungert
Copy link
Collaborator

@dbungert dbungert commented Jul 26, 2023

Skips the install when it's already there, does the right thing if .tox not present / old dependency / missing dependency.

Copy link
Collaborator

@mwhudson mwhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot better -- 1.2 vs 7.5s on my system. Running the commands directly is about 0.6s (isort is way slower than black!) so there's still some overhead but way less. Thanks!

@dbungert dbungert merged commit 0969abc into canonical:main Jul 26, 2023
12 checks passed
@dbungert dbungert deleted the tox-but-faster branch July 26, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants