Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: fix probert, add curtin runners #1747

Merged
merged 1 commit into from Aug 2, 2023

Conversation

dbungert
Copy link
Collaborator

@dbungert dbungert commented Aug 1, 2023

Make it so that probert and curtin can be run from the snap. Invoked as subiquity.probert and subiquity.curtin respectively.

@dbungert
Copy link
Collaborator Author

dbungert commented Aug 1, 2023

I also experimented with a refactor to reduce the number of environment variables being set in snapcraft.yaml, but that broke the TUI, so I'm sending the working part for now.

Copy link
Collaborator

@mwhudson mwhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested this, it looks good! Thanks for doing it.

bin/subiquity-cmd Show resolved Hide resolved
Make it so that probert and curtin can be run from the snap.  Invoked as
subiquity.probert and subiquity.curtin respectively.
@dbungert dbungert merged commit f088fa2 into canonical:main Aug 2, 2023
11 checks passed
@dbungert dbungert deleted the snap-curtin-cmd branch August 2, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants