Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions to test local changes in kvm #1846

Merged
merged 2 commits into from Oct 24, 2023

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Oct 20, 2023

As reported in LP:#2039966, the instructions we provide to test local changes in KVM were not enough to cover changes in curtin or probert.

Updated README.md with some pointers and also replaced uses of snapcraft snap by snapcraft pack to avoid deprecation warnings.

Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Copy link
Contributor

@Chris-Peterson444 Chris-Peterson444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I definitely stumbled over this when I got started but I never got around to updating the docs (Sorry!). Just one comment. Thanks!

README.md Outdated Show resolved Hide resolved
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
@ogayot ogayot merged commit 288691f into canonical:main Oct 24, 2023
12 checks passed
@ogayot ogayot deleted the snapcraft-doc branch October 24, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants