Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apport reporting #1851

Merged

Conversation

Chris-Peterson444
Copy link
Contributor

Some name and file location changes to be consistent with the (to be upload) updated subiquity hook in apport.

The only source of the traceback - if any - is the one in memory that we grab and manually attach to the report. We also need to explicitly write out the traceback information when we crash, otherwise a call to ubuntu-bug or similar won't be able to pick it up.

@Chris-Peterson444
Copy link
Contributor Author

Chris-Peterson444 commented Oct 23, 2023

@Chris-Peterson444
Copy link
Contributor Author

Here are some example crash reports for these changes:

Subiquity's geneated crash report: https://bugs.qastaging.launchpad.net/subiquity/+bug/1743387
Apport's generated crash report: https://bugs.qastaging.launchpad.net/subiquity/+bug/1743388

Since these links will be dead after some time, here are the corresponding crash files (renamed to .log so github will let me post them):
apport-crash.log
subiquity-crash.log

@Chris-Peterson444 Chris-Peterson444 marked this pull request as ready for review October 23, 2023 21:54
@Chris-Peterson444
Copy link
Contributor Author

In preparing this I've come to realize that while apport-cli states that using the -c flag will only upload the crash file, it appears to also run the package hook, if found, and overwrite any of the fields already in the report. This also means things like InstallerJournal and SystemJournal may both be present in the report. I will update the hook to only include SystemJournal if InstallerJournal is not found.

This is mostly an issue for the server installer, where a crash requires the user to manually report the bug using ubuntu-bug or apport-cli. Although I will need to confirm if this is the case when running ubuntu-desktop-installer.

An additional note is that given the current permissions of /var/installer/log/ a user is required to run ubuntu-bug or apport-cli with sudo.

@Chris-Peterson444 Chris-Peterson444 merged commit 560b0b2 into canonical:main Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants