Revert orig_environ fix in command controllers #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commands" This reverts commit 39f1ea9. The fix proposed in this patch caused more issues than it fixed. We will have to revisit this in a more nuanced way in the future. In the meantime users can make use of env directly to strip/modify the subcommand environment.
Chris-Peterson444
force-pushed
the
undo-os-environ-changes
branch
from
6b85d6f
to
0a70a96
Compare
|
Good catch. Fixed to only revert 39f1ea9, thanks! |
This commit re-adds some of the shared mock fields for testing and removes a bad import from test_snaplist. These are changes that shouldn't have been part of the previously reverted patch: 0a70a96
dbungert
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 39f1ea9. The fix proposed in this patch caused more issues than it fixed. We will have to revisit this in a more nuanced way in the future. In the meantime users can make use of env directly to strip/modify the subcommand environment.