Fix emtpy list of authorized_keys in /ssh endpoint #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
The SSHModel contained a ssh_import_id member variable. According to the comment, it was originally meant to store meta-data about a SSH key ; and was supposed to allow showing some sort of info back in the SSH view if the user decides to go back. I suspect that this variable has been unused for a long time. Furthermore, it can only hold information about a single SSH key and we support multiple keys.. Let's get rid of it. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
mwhudson
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Eh well. The return type of the GET is only the same as POST out of laziness really I think. This is more correct though and would help enable a better interface on the client side (really the client UI should let you download as many keys as you want to and then allow you to proceed rather than fetching as part of moving to the next screen...)
Actually I started all that last year and never got the opportunity to finish it. Will try to dig it up and show what it looked like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /ssh endpoint was, I think, meant to return a list of authorized_keys but it didn't.
Fixed the issue and also removed a variable that probably has been unused for years now.