Late commands vs done #2013
Merged
Late commands vs done #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
force-pushed
the
late-commands-vs-done
branch
from
2fc7899
to
46c857e
Compare
ogayot
reviewed
Jun 20, 2024
Today, late-commands can in some cases not actually run, if the application reports a DONE state and a reboot is permitted. We now add LATE_COMMANDS to track this explicit state - we no longer transition to a DONE state while these commands are running.
Last cycle, to make the installation faster, we decided to disable the unattended-upgrades minimal steps. This prevents proper handling of unattended-upgrades cancellation so we now drop the feature completely. Furthermore, the status reported on the text installer UI is misleading when unattended-upgrades is running.
ogayot
force-pushed
the
late-commands-vs-done
branch
from
46c857e
to
a39fb03
Compare
|
NOTE: This was related to how I injected the new subiquity code into an existing ubuntu-desktop-bootstrap snap without regenerating the types. Dennis confirmed that the fix was working after regenerating the types. |
mwhudson
reviewed
Jun 21, 2024
…ommand Since we removed the ability to interrupt the unattended-upgrades process, we can use run_curtin_command instead of start_curtin_command. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
late-commands-vs-done
branch
from
94f6e6c
to
ae581d9
Compare
Chris-Peterson444
approved these changes
Jun 24, 2024
dbungert
commented
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.