adopt curtin capabilities related to kernel in lowest layer #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Peterson444
approved these changes
Jun 20, 2024
mwhudson
reviewed
Jun 21, 2024
subiquity/models/kernel.py
Outdated
| result["kernel"]["install"] = False | ||
| else: | ||
| result["kernel"]["package"] = self.needed_kernel | ||
| return result |
There was a problem hiding this comment.
tangent: would be nice if we could use the rich curtin config types we've added here wouldn't it ...
dbungert
force-pushed
the
kernel-lowest-layer
branch
from
93e3e28
to
409ba7f
Compare
We can lean on curtin to handle cases of kernels being pre-installed in the image, just need to opt into it. Drop existing list_kernels logic, if we need it again we can leverage the logic from curtin.distro.
dbungert
force-pushed
the
kernel-lowest-layer
branch
from
409ba7f
to
2f674dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.