refactor how mirror data is handled #626
Conversation
subiquity/models/mirror.py
Outdated
|
|
||
|
|
||
| def get_default_mirror(): | ||
| return get_mirror(DEFAULT, "primary", get_architecture()) |
There was a problem hiding this comment.
Could we move the get_mirror() call to the object initialization so we can cache it? It won't change during the lifetime of the install so we can save some execs and overhead if we keep it around.
There was a problem hiding this comment.
Alternatively, we recently made use of python3's lru_cache() in cloud-init
from functools import lru_cache()
@lru_cache()
def get_default_mirror()
...
There was a problem hiding this comment.
Tweaked a bit, see what you think now.
This is prep work for allowing autoinstalls to specify a complete apt config.
mwhudson
force-pushed
the
mirror-tweaks
branch
from
c0e5ce3
to
52fc18b
Compare
subiquity/models/mirror.py
Outdated
| ], | ||
| } | ||
|
|
||
| ARCHITECTURE = get_architecture() |
There was a problem hiding this comment.
Doesn't this create a side-effect of executing dpkg if something imports this module?
There was a problem hiding this comment.
AFAICT, nothing outside of this module uses DEFAULT_MIRROR or ARCHITECTURE and the API being used are the method son the MirrorModel itself, could we move these values to the class itself? then they can be properties that are cached after initialization in init?
There was a problem hiding this comment.
Yeah, that makes more sense, thanks.
mwhudson
force-pushed
the
mirror-tweaks
branch
from
417ca73
to
2c1d350
Compare
This is prep work for allowing autoinstalls to specify a complete apt
config.