locale - let it check interactive-sections again #937
Conversation
LP: #1919251
|
When this was introduced, the comment was: Is that still relevant? |
|
Oh hah I'd forgotten that rationale. No, that's not a valid reason any more -- but there is still one thing I'd like to fix, which is to move the question we ask on the serial console about switching to 'rich mode' somewhere more generic so that it still gets asked even if locale is not interactive. Basically I think this means making a "Stretchy" to ask the question and showing it with add_global_overlay() just after starting the urwid event loop -- if you look at how error reports or cloud-init failures are reported at startup, like that! |
Rather than asking for ssh_info then passing it to the grandchild, let the grandchild ask for it if needed.
If we don't need to do title renaming, then we don't need the exact controller, and we can drop the controller from the SerialChoices.
Run it in base client so we still see it in the interactive sections case where we skip the Welcome screen.
|
Very nice, this is exactly what I asked for. Unfortunately (and this is my fault), this does have one regression in functionality though: we probably shouldn't offer a choice of languages in non-rich mode (as most non-English languages will just display as a mess of '?'s). So perhaps instead of being an overlay, the question about rich mode should be its own screen (complete with client/controllers/richmode I guess) that can skip on non-serial. Or we can add some way to skip past the language screen if it's showing when the user selects "continue in basic mode". What do you think? Sorry to mess you around like this. |
When in serial, first offer the rich/basic choice (or SSH button), and only show the current welcome screen if we choose rich mode. Add a back button on Welcome if we are on serial.
dbungert
force-pushed
the
interactive-and-locale
branch
from
2dd2f5e
to
9f7e588
Compare
|
@mwhudson - thanks, all feedback items should be addressed, would you confirm? |
* locale - let it check interactive-sections again * Turn Serial into a whole new screen When in serial, first offer the rich/basic choice (or SSH button), and only show the current welcome screen if we choose rich mode. Add a back button on Welcome if we are on serial. LP: #1919251
LP: #1919251