Fix grpc port conflict #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
approved these changes
Jul 11, 2023
dstathis
approved these changes
Jul 11, 2023
sed-i
reviewed
Jul 11, 2023
| @@ -23,7 +23,7 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| @trace_charm(tempo_endpoint="_tempo_otlp_grpc_endpoint", service_name="TempoCharm") | |||
| @trace_charm(tempo_endpoint="_tempo_otlp_grpc_endpoint") | |||
There was a problem hiding this comment.
Is there anything other than 'charm'? I.e. should it be shortened to just @trace(...)?
There was a problem hiding this comment.
didn't see this one until now, but yeah, there's trace_function, trace_type.
Idea is:
@trace_function
def my_custom_fn()...
@trace_type
class MyObj...
@trace_charm(...)
class MyCharm...
def foo(self):
my_custom_fn() # we'll open a span corresponding with `my_custom_fn` being called
obj = MyObj() # each method call on this type will open a span
obj.bar()In fact, trace_charm is a specialization of trace_type.
I thought about having a @trace that automagically dispatches to one of the three based on the type (and subclass) of the first argument, but it felt out of scope for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promtail tries to use port 9095 for its grpc listen server, but tempo has already snatched it.
This PR sets a different grpc listen port for Tempo.