Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Uses the hash of the CSR as a secret label #188

Merged
merged 1 commit into from
May 31, 2024
Merged

chore: Uses the hash of the CSR as a secret label #188

merged 1 commit into from
May 31, 2024

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented May 31, 2024 •
edited
Loading

Description

Fixes #139
We replace the usage of CSRs as secret labels with the hexadecimal representation of their sha256 hash.
The goal is to avoid having special characters in the secret label.

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have bumped the version of any required library.

@saltiyazan saltiyazan requested a review from a team as a code owner May 31, 2024 10:51
gruyaume
gruyaume reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that this fixes #139 in the PR description

@saltiyazan saltiyazan requested a review from gruyaume May 31, 2024 11:32
@saltiyazan saltiyazan merged commit e8fde14 into main May 31, 2024
19 checks passed
@saltiyazan saltiyazan deleted the TLSENG-134-improve-secret-labels branch May 31, 2024 12:09
@saltiyazan saltiyazan mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regular expression is invalid error when certificates-relation-changed
2 participants
@saltiyazan @gruyaume