-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradients #13
Update gradients #13
Conversation
@waynecrosby I've assigned you to this so you can review it from a design/brand perspective. |
Thanks @steverydz
|
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
Thanks @waynecrosby I've updated the orange as requested, changed the opacity of the two white suru elements to 0.03 and 0.05, moved the position of the black suru element and changed it's opacity to 0.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good... the only thing I have seen is when the h1 is short like 'Internet of Things' a few have the image pretty low... perhaps Wayne can comment on the right thing to do in this case.
@pmahnke @waynecrosby the illustration is centred vertically and horizontally within it's container. I can make the image box the same height as the total text height. I'll do that in another PR though because it will require a fair bit of refactoring. @waynecrosby If you're happy with these gradients I'll merge the PR |
@steverydz Not sure why but the gradient doesn't seem to be as bright as in Sketch? Can you try this orange to see if it lifts it #B94E47. |
@waynecrosby I've updated the gradient orange. For the text/image alignment I've made a new issue (#14) |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
1 similar comment
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby did you have any thoughts about the updated gradient? |
@steverydz It's looking much better, one thought I had was if you can have more aubergine so that the orange gradient starts further into the corner. |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby I've updated it - what do you think? |
@steverydz The gradient should have 3 colours, are you using the below values?: In Sketch we use #e95420 orange but we finish it off canvas as it's too bright going to that in the corner, that is why I've given you the orange value above to use as that is what appears in the corner in Sketch. You can see what I mean in the image below: |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby I've just pushed another update. This is how it's constructed: From bottom left to top right:
Then the overlays are:
|
@steverydz I think it's nearly there, I think the percentages are good, it's just that last orange shade we need to get right, could you try changing #ba534a (94% to 100%) to #c44e43 (94% to 100%). Thanks |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby done, how does it look? |
@steverydz I'm so sorry, can we try one more: #d1573c - if this one doesn't look right I think we revert to #ba534a |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby ok, updated |
@steverydz I think we revert to where you were as it's the closest to the Sketch file. Apologies for the back and forth: |
Starting demo at: https://social-banners-canonical-web-and-design-pr-13.run.demo.haus/ |
@waynecrosby no worries, it's worth getting it right :) I've updated as you said - if this is OK I'll get this merged. |
@steverydz Great, looking good! |
@steverydz Are you adjusting the illustration positioning on another issue? |
@waynecrosby Yes #14 |
Done
Add gradient overlay styles for all banner backgrounds
QA
./run serve
Issue / Card
Fixes #2