Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradients #13

Merged
merged 12 commits into from
Jul 8, 2020
Merged

Update gradients #13

merged 12 commits into from
Jul 8, 2020

Conversation

steverydz
Copy link
Contributor

Done

Add gradient overlay styles for all banner backgrounds

QA

Issue / Card

Fixes #2

@steverydz
Copy link
Contributor Author

@waynecrosby I've assigned you to this so you can review it from a design/brand perspective.

@waynecrosby
Copy link

Thanks @steverydz
A couple of comments about the Ubuntu gradient & suru:

  1. The orange is looking a bit murky brown, could you make the grad go from the aubergine to #B9463C
  2. There should be 3 suru elements, 2 white (3% & 5% opacity) and 1 black (5% opacity)
  3. The balck suru is in the wrong position, see below where it should be

Screenshot 2020-07-06 at 13 02 41

Hopefully that should brighten it up, let me know if not clear. Thanks

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

Thanks @waynecrosby

I've updated the orange as requested, changed the opacity of the two white suru elements to 0.03 and 0.05, moved the position of the black suru element and changed it's opacity to 0.0.5

Copy link
Contributor

@pmahnke pmahnke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good... the only thing I have seen is when the h1 is short like 'Internet of Things' a few have the image pretty low... perhaps Wayne can comment on the right thing to do in this case.

@steverydz
Copy link
Contributor Author

@pmahnke @waynecrosby the illustration is centred vertically and horizontally within it's container. I can make the image box the same height as the total text height. I'll do that in another PR though because it will require a fair bit of refactoring.

@waynecrosby If you're happy with these gradients I'll merge the PR

@waynecrosby
Copy link

@steverydz Not sure why but the gradient doesn't seem to be as bright as in Sketch? Can you try this orange to see if it lifts it #B94E47.
Also, as Peter said, when the copy is short the illustration on the taller banners stays too low, if you can try and centre it vertically in the gap left that would be great.
With 'Facebook & LinkedIn - 1200 x 628' when the copy is short as above, can you move the copy down to be more vertically centred as in this version 'Twitter wide - 800 x 418'. Thanks

@steverydz
Copy link
Contributor Author

@waynecrosby I've updated the gradient orange.

For the text/image alignment I've made a new issue (#14)

@webteam-app
Copy link

1 similar comment
@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby did you have any thoughts about the updated gradient?

@waynecrosby
Copy link

@steverydz It's looking much better, one thought I had was if you can have more aubergine so that the orange gradient starts further into the corner.
Screenshot 2020-07-08 at 10 05 58

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby I've updated it - what do you think?

@waynecrosby
Copy link

@steverydz The gradient should have 3 colours, are you using the below values?:
#2C001E --> #772953 --> #BA534A

In Sketch we use #e95420 orange but we finish it off canvas as it's too bright going to that in the corner, that is why I've given you the orange value above to use as that is what appears in the corner in Sketch. You can see what I mean in the image below:
Screenshot 2020-07-08 at 10 34 25

@webteam-app
Copy link

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby I've just pushed another update.

This is how it's constructed:

From bottom left to top right:

  • #2c001e (0% to 62%)
  • #772953 (62% to 94%)
  • #ba534a (94% to 100%)

Then the overlays are:

  • Top: rgba(255, 255, 255, 0.03)
  • Bottom: rgba(255, 255, 255, 0.05)
  • Top left: rgba(0, 0, 0, 0.05)

@waynecrosby
Copy link

@steverydz I think it's nearly there, I think the percentages are good, it's just that last orange shade we need to get right, could you try changing #ba534a (94% to 100%) to #c44e43 (94% to 100%). Thanks

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby done, how does it look?

@waynecrosby
Copy link

@steverydz I'm so sorry, can we try one more: #d1573c - if this one doesn't look right I think we revert to #ba534a

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby ok, updated

@waynecrosby
Copy link

@steverydz I think we revert to where you were as it's the closest to the Sketch file. Apologies for the back and forth:
#2c001e (0% to 62%)
#772953 (62% to 94%)
#ba534a (94% to 100%)

@webteam-app
Copy link

@steverydz
Copy link
Contributor Author

@waynecrosby no worries, it's worth getting it right :)

I've updated as you said - if this is OK I'll get this merged.

@waynecrosby
Copy link

@steverydz Great, looking good!

@waynecrosby
Copy link

@steverydz Are you adjusting the illustration positioning on another issue?

@steverydz
Copy link
Contributor Author

steverydz commented Jul 8, 2020

@steverydz Are you adjusting the illustration positioning on another issue?

@waynecrosby Yes #14

@steverydz steverydz merged commit 93d504c into canonical:master Jul 8, 2020
@steverydz steverydz deleted the fix-gradients branch July 8, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add suru gradient styles to each variant
4 participants