Use entire chain for the server cert #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re the static error: issue is that we can't tell the static checker that in that code block we're working with pydantic v1. |
sed-i
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti and
simskij
as code owners
Abuelodelanada
approved these changes
Mar 26, 2024
|
Given the specific upgrade instructions, should we take precautions as we publish this to edge, or do we go ahead and merge? |
sed-i
force-pushed
the
feature/chain-pem
branch
2 times, most recently
from
f479d12
to
f138026
Compare
sed-i
force-pushed
the
feature/chain-pem
branch
from
f138026
to
294e5aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Certificates generated by the charm don't include intermediates: canonical/httprequest-lego-k8s-operator#93.
Solution
Fetch-lib and use the new
.chain_as_pemmethod.In tandem with: