Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic gazebo classic #2

Merged
merged 15 commits into from
Feb 27, 2023
Merged

Conversation

Guillaumebeuzeboc
Copy link
Collaborator

These are the changes to build a snap for ROS noetic compatible with the TB3 robot as well as the Gazebo classic simulation.
The main differences are:

  • use of the snap daemons functionalities for map saving and others
  • maps are now saved in SNAP_USER_COMMON/map (user being root in snap daemons)
  • the core daemon can be enabled to run next to the Gazebo classic simulation
  • the robot can be teleoperated by the keyboard or a joystick

This PR is meant to be compatible with turtlebot3c noetic-devel

This PR is a replacement for #1

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/local/mux_select_nav_vel.sh Show resolved Hide resolved
@Guillaumebeuzeboc
Copy link
Collaborator Author

An idea I had. With:

+
+# enable navigation or even restart it on a new map
+snapctl start --enable turtlebot3.navigation
+

we could automatically enable and start the navigation right after saving the map. This way the snap is first installed with the navigation disabled. And as soon as you run the mapping once it automatically enables the navigation.
What do you think? is it too much?

@Guillaumebeuzeboc
Copy link
Collaborator Author

An idea I had. With:

+
+# enable navigation or even restart it on a new map
+snapctl start --enable turtlebot3.navigation
+

we could automatically enable and start the navigation right after saving the map. This way the snap is first installed with the navigation disabled. And as soon as you run the mapping once it automatically enables the navigation. What do you think? is it too much?

No need for that since it would complicate the snap for not much feature

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@artivis artivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a last small suggestion. Otherwise LGTM 👍 !

Co-authored-by: Jeremie Deray <jeremie.deray@canonical.com>
@Guillaumebeuzeboc Guillaumebeuzeboc merged commit 4921f75 into noetic-devel Feb 27, 2023
@artivis artivis deleted the noetic-gazebo-classic branch June 9, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants