mantic: broken automatic partition setup

[jbicha]

• Ubuntu Desktop 23.10 "mantic" 2023-07-18

Test Case

I am using Ubuntu 23.10 as my host. In GNOME Boxes, I created a 23.10 guest using today's ISO.

I clicked all the default options until I get to this confirmation screen with missing details in the devices and partitions sections.

Afterwards, I clicked Install and finished the rest of the dialog but it looked like the installer couldn't actually install anything so I was just left at the slideshow stage. No other errors or glitches were shown.

[jpnurmi]

Hey @jbicha, do you still have access to the system? Any chance to get the logs from /var/log/installer?

[jpnurmi]

Never mind, I'm just too used to bumping up the VM specs! 🤦‍♂️ I was able to reproduce the issue with the default 25.0 GiB storage.

[jpnurmi]

We need to add handling for the TOO_SMALL reason introduced in canonical/subiquity#1694.

2023-07-18 18:48:14.733330 DEBUG subiquity_client: GET http://localhost/storage/v2/guided?wait=true
2023-07-18 18:48:14.734688 DEBUG subiquity_client: ==> getGuidedStorageV2(true) {"status": "DONE", "error_report": null, "configured": null, "targets": [{"disk_id": "disk-vda", "allowed": [], "disallowed": [{"capability": "DIRECT", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM_LUKS", "reason": "TOO_SMALL", "message": null}], "$type": "GuidedStorageTargetReformat"}, {"allowed": ["MANUAL"], "disallowed": [], "$type": "GuidedStorageTargetManual"}]}

[jpnurmi]

With the default 25 GiB disk gnome-boxes offers for Ubuntu 23.10, Subiquity refuses guided reformat (TOO_SMALL) even though manual installation with the simplest possible partition layout installs fine.

• GET /storage/v2/orig_config

  {"status": "DONE", "error_report": null, "disks": [{"id": "disk-vda", "label": "/dev/vda", "type": "local disk", "size": 26843545600, "usage_labels": [], "partitions": [{"offset": 1048576, "size": 26841448448, "usable": "YES", "$type": "Gap"}], "ok_for_guided": true, "ptable": null, "preserve": true, "path": "/dev/vda", "boot_device": false, "can_be_boot_device": true, "model": null, "vendor": null}], "need_root": true, "need_boot": true, "install_minimum_size": 17297309696}

• GET a/storage/v2/guided

  {"status": "DONE", "error_report": null, "configured": null, "targets": [{"disk_id": "disk-vda", "allowed": [], "disallowed": [{"capability": "DIRECT", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM", "reason": "TOO_SMALL", "message": null}, {"capability": "LVM_LUKS", "reason": "TOO_SMALL", "message": null}], "$type": "GuidedStorageTargetReformat"}, {"allowed": ["MANUAL"], "disallowed": [], "$type": "GuidedStorageTargetManual"}]}

• POST a/storage/v2/add_partition {"disk_id": "disk-vda", "size": "26841448448", "wipe": "superblock", "mount": "/", "format": "ext4"}

  {"status": "DONE", "error_report": null, "disks": [{"id": "disk-vda", "label": "/dev/vda", "type": "local disk", "size": 26843545600, "usage_labels": [], "partitions": [{"size": 1127219200, "number": 2, "preserve": false, "wipe": "superblock", "annotations": ["new", "primary ESP", "to be formatted as fat32", "mounted at /boot/efi"], "mount": "/boot/efi", "format": "fat32", "grub_device": true, "boot": true, "os": null, "offset": 1048576, "estimated_min_size": -1, "resize": null, "path": "/dev/vda2", "$type": "Partition"}, {"size": 25714229248, "number": 1, "preserve": false, "wipe": "superblock", "annotations": ["new", "to be formatted as ext4", "mounted at /"], "mount": "/", "format": "ext4", "grub_device": null, "boot": false, "os": null, "offset": 1128267776, "estimated_min_size": -1, "resize": null, "path": "/dev/vda1", "$type": "Partition"}], "ok_for_guided": true, "ptable": "gpt", "preserve": false, "path": "/dev/vda", "boot_device": true, "can_be_boot_device": true, "model": null, "vendor": null}], "need_root": false, "need_boot": false, "install_minimum_size": 17297309696}

• POST a/storage/v2 => POST a/meta/confirm => success

[jbicha]

Actually, I tried with 20GB which I believe was enough for Ubuntu 23.04.

[jpnurmi]

Fixed by:

• filesystem: fix ~6GB extra pad on classic min size subiquity#1729

The fix didn't make it on today's live but I tested with a 20GB disk and snap refresh ubuntu-desktop-installer and it installed fine. 👍

latest/stable:    0+git.7fe84a1e 2023-07-20 (1165) 135MB classic