Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filesystem: fix ~6GB extra pad on classic min size #1729

Merged
merged 1 commit into from Jul 20, 2023
Merged

filesystem: fix ~6GB extra pad on classic min size #1729

merged 1 commit into from Jul 20, 2023

Conversation

dbungert
Copy link
Collaborator

@dbungert dbungert requested a review from mwhudson July 19, 2023 16:25
mwhudson
mwhudson approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@mwhudson mwhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oops, thanks for catching my mistake here.

It's sort of annoying that calculate_suggested_install_min has to take a part_align argument. I wonder if we could just make it assume the largest alignment of any ptable type or something, I don't think that would make much difference in practice?

@dbungert
Copy link
Collaborator Author

It's sort of annoying that calculate_suggested_install_min has to take a part_align argument. I wonder if we could just make it assume the largest alignment of any ptable type or something, I don't think that would make much difference in practice?

I would be ok with that. It's meant to be an estimate, but I do like that it give an aligned answer.

@dbungert dbungert merged commit 9a57299 into canonical:main Jul 20, 2023
10 checks passed
@dbungert dbungert deleted the udi-2252 branch July 20, 2023 00:34
@mwhudson
Copy link
Collaborator

It's sort of annoying that calculate_suggested_install_min has to take a part_align argument. I wonder if we could just make it assume the largest alignment of any ptable type or something, I don't think that would make much difference in practice?

I would be ok with that. It's meant to be an estimate, but I do like that it give an aligned answer.

I have a better idea! #1732

@jpnurmi jpnurmi mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwhudson mwhudson mwhudson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dbungert @mwhudson