This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
[WSL] Adds an opt-out option for installing language packs #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we request _languages[0] during the first build and the list being empty would result in an exception.
The new endpoint is available since 68b92f10229560cc34f780500da5a6f8955909f5
|
Sorry for the long delay. :) The change looks good! Do you think we could first upgrade Subiquity separately, though? It probably brings in several unrelated changes and fixes. |
jpnurmi
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
LGTM 👍
The list of Subiquity changes is not that bad, actually:
Merge pull request canonical/subiquity#1400 from CarlosNihelton/optional-controller
Merge pull request canonical/subiquity#1390 from CarlosNihelton/langpack-flag
Merge pull request canonical/subiquity#1395 from blackboxsw/cloud-init/desktop-disable-cloud-init
Merge pull request canonical/subiquity#1399 from dbungert/runtests-trap-kill
Merge pull request canonical/subiquity#1392 from ogayot/speed-up-integration-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is outlined in #1073.
This closes #1073 by:
Since the new endpoint is optional even for the setup workflow, it's still possible to start the wizard at a different page, as demonstrated in the second integration test case.
Also this was made somewhat flexible, so in the future it will be easy to move this flag to a new page if the need for more options with related semantics raise.