This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Post-pone guided storage choice #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A guided storage choice consists of multiple attributes: - which disk/partition to use - whether to use lvm - whether to use encryption - security key These inputs are collected from multiple pages: - installation type - select guided storage - install x alongside y - choose security key The problem is that Subiquity only allows setting guided storage once. That is, we cannot "update" the existing guided storage selection as we go but we need to wait until all attributes have been gathered and then apply it all in one go. The best place for this is when arriving at the "Write changes to disk" page where the storage changes are summarized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A guided storage choice consists of multiple attributes:
These inputs are collected from multiple pages:
The problem is that Subiquity only allows setting guided storage once.
That is, we cannot "update" the existing guided storage selection as we
go but we need to wait until all attributes have been gathered and then
apply it all in one go. The best place for this is when arriving at the
Write changes to disk page where the storage changes are summarized.
These changes were extracted from #951.