Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Where are you: swap timezone map & dropdowns #1191

Merged
merged 1 commit into from Feb 23, 2023

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Oct 17, 2022

Leaving a 180px vertical gap below the dropdowns makes the timezone map look squeezed (the slightly wrong window height (#697) makes it even worse). Therefore, I'd propose swapping the order to let the popups open over the timezone map.

Before Design Proposal
image image image
image image image
image image image

Design: https://people.canonical.com/~platform/desktop/installer/13.%20Where%20Are%20You/#artboard0
Resolves: #1189

@jpnurmi jpnurmi added the UX/UI UX or UI related issue label Oct 17, 2022
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Oct 24, 2022

@elioqoshi There's an issue in Flutter that dropdowns always open downwards even if there's no space. Would it be a reasonable workaround to change the page layout so that the dropdowns are at the top until Flutter might fix them to open upwards when there's no space below?

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Feb 10, 2023

Flutter 3.7 introduced a new M3 DropdownMenu that seemed to open upwards when at the bottom of the screen. We could give it a try for this.

@jpnurmi jpnurmi marked this pull request as draft February 10, 2023 10:54
@elioqoshi
Copy link

@jpnurmi Sorry I missed this before. Let me know if I should review it, the original proposal makes sense and I think the dropdown should be a primary way of selecting your timezone anyway

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Feb 21, 2023

@elioqoshi The looks have evolved a little since the proposal was originally created but here's how it would look like today. Does it still look ok to you?

image
image
image

@jpnurmi jpnurmi marked this pull request as ready for review February 21, 2023 08:11
@elioqoshi
Copy link

This is fully accessible via keyboard, right? Then it looks good to me!

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Feb 21, 2023

Great, thanks! Yes, these are fully accessible via keyboard 👍

@jpnurmi jpnurmi requested a review from d-loose February 23, 2023 12:42
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpnurmi jpnurmi merged commit bde1cee into canonical:main Feb 23, 2023
@jpnurmi jpnurmi deleted the location-dropdowns branch February 23, 2023 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UX/UI UX or UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locations popdown is cut at the bottom edge of the dialog
3 participants