This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Installation slides: fix RTL & adjust fonts, colors, line spacing, and paddings #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jpnurmi
force-pushed
the
installation-slides
branch
from
aa9f633
to
4feb552
Compare
This fixes the issue that some slides had overflows when translated. Most importantly, overflows are now caught in the CI whenever Weblate opens PRs for translation updates, for example. Running the included test without the font and layout tweaks would result in the following screenshots being dumped into `integration_test/goldens/failures`: - installation-slide-music-ru.png - installation-slide-music-uk.png - installation-slide-photos-fr.png - installation-slide-photos-hu.png - installation-slide-photos-ja.png - installation-slide-photos-pl.png - installation-slide-photos-ru.png - installation-slide-photos-uk.png Fixes: canonical#1388
jpnurmi
force-pushed
the
installation-slides
branch
from
4feb552
to
8f88f77
Compare
jpnurmi
changed the title
|
252 screenshots of the slides: https://drive.google.com/drive/folders/18zZYITxQk8ZWMmj7-EIWqbasnmCqzExo?usp=sharing (internal) |
seb128
approved these changes
Feb 10, 2023
|
Thanks! :) @elioqoshi I tried to keep the visual changes to a minimum. Just ping me if you have time to go through the slides and if there's anything you want to change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that some slides overflowed when translated. The tweaks are subtle but free up a sufficient amount of space so that all translations fit on the screen.
Most importantly, overflows are now caught in the CI whenever Weblate opens PRs for translation updates, for example. Running the included test without the font and layout tweaks would result in the following screenshots being dumped into
integration_test/goldens/failures:Fixes: #1373