This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Adapt to new subiquity WSL API #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
force-pushed
the
new-system-setup-api
branch
2 times, most recently
from
7fea70f
to
834f353
Compare
didrocks
changed the title
didrocks
changed the title
subiquity is now following the <section>_<key> from wsl.conf for its API to avoid another internal mapping. Follow that change. Make it thus camelCase for properties separating section and key like sectionKey.
didrocks
force-pushed
the
new-system-setup-api
branch
from
d35f2aa
to
6ceb468
Compare
jpnurmi
reviewed
Oct 7, 2021
jpnurmi
reviewed
Oct 7, 2021
|
Thanks! I forgot to press the approve button but LGTM 👍 |
|
Great, thanks a lot :) Sorry for the API wrong replacement |
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Oct 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEENG-84
subiquity is now following the
to avoid another internal mapping. Follow that change.
Make it thus camelCase for properties separating section and key like
sectionKey.
Keeping it as a draft until canonical/subiquity#1066 is merged and referenced in submodule.