This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Speed up allocate_disk_space_page_test #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, find.widgetWithText() takes awfully long for finding
an OutlinedButton with specific text in the confirmation dialog's
widget tree. Replacing it with find.text() makes the operation almost
instant. This does the job fine in this context because tap events
propagate from the non-interactive text label to the OutlinedButton
ancestor.
Before, ~20s:
$ flutter test test/allocate_disk_space
00:20 +40: All tests passed!
After, ~5s:
$ flutter test test/allocate_disk_space
00:05 +40: All tests passed!
oSoMoN
approved these changes
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, find.widgetWithText() takes awfully long for finding
an OutlinedButton with specific text in the confirmation dialog's
widget tree. Replacing it with find.text() makes the operation almost
instant. This does the job fine in this context because tap events
propagate from the non-interactive text label to the OutlinedButton
ancestor.
Before, ~20s:
After, ~5s: