This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Match RadioButton & CheckButton with the design #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
force-pushed
the
radio-icon-tile
branch
from
0bc8778
to
cec2880
Compare
RadioIconTile was originally added for aligning arbitrary widgets with RadioListTile. It has been replaced by RadioButton, which has similar but not identical layout. This change fixes the layout mismatch by adapting RadioButton's layout to RadioIconTile, and then reusing it for implementing RadioButton's and CheckButton's layout. This eliminates a nice chunk of duplication between RadioButton and CheckButton, and ensures that all three stay in sync.
jpnurmi
force-pushed
the
radio-icon-tile
branch
from
cec2880
to
65093bd
Compare
The indicator is vertically aligned with the title.
jpnurmi
changed the title
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Mar 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indicator is vertically aligned with the title.
Ref: #31