This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Remove old typeOf() workarounds #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restriction on passing generic type arguments was removed in Dart 2.14. https://medium.com/dartlang/announcing-dart-2-14-b48b9bb2fb67 > We’ve also removed an old restriction on type arguments, which > disallowed using generic function types as a type argument. All of > the following were invalid before 2.14, but are now allowed: Dart 2.14 was shipped with Flutter 2.5. The current stable versions are 2.16 and 2.10, respectively.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
typeOf<T>()andfind.byTypeOf()helpers in favor of thestandard
find.byType(T). The restriction on passing generic type arguments wasremoved in Dart 2.14.
https://medium.com/dartlang/announcing-dart-2-14-b48b9bb2fb67
Dart 2.14 was shipped with Flutter 2.5. The current stable versions are
2.16 and 2.10, respectively.