This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Remove superfluous KeyboardService #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyboard layout loading used to be a much more complicated process that involved non-trivial data structures. The KeyboardService class (or KeyboardModel as it was called then) was introduced to help with that complexity. These days, loading the layouts is so straightforward that a separate KeyboardService no longer serves a purpose. Any view model can get the list of layouts by calling SubiquityClient.keyboard(), which returns a KeyboardSetup that contains a List<KeyboardLayout> that can be used as is. There's no parsing, tuples, or maps involved anymore, where some help was needed. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard layout loading used to be a much more complicated process that
involved non-trivial data structures. The KeyboardService class (or
KeyboardModel as it was called then) was introduced to help with that
complexity.
These days, loading the layouts is so straightforward that a separate
KeyboardService no longer serves a purpose. Any view model can get the
list of layouts by calling SubiquityClient.keyboard(), which returns a
KeyboardSetup that contains a List<KeyboardLayout> that can be used as
is. There's no parsing, tuples, or maps involved anymore, where some
help was needed. :)