take first capability from allowed as default #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before canonical/subiquity#1774 the order of the capabilities in `allowed` was arbitrary, resulting in https://bugs.launchpad.net/ubuntu-desktop-installer/+bug/2033093 and other confusing behaviour. The subiquity PR puts the capability that should be considered the default first, so that's what the client side code should do to.
|
I haven't tested this (in fact I made this branch by clicking around in github, not even locally) |
dbungert
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before canonical/subiquity#1774 the order of the capabilities in
allowedwas arbitrary, resulting in https://bugs.launchpad.net/ubuntu-desktop-installer/+bug/2033093 and other confusing behaviour. The subiquity PR puts the capability that should be considered the default first, so that's what the client side code should do too.