Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): don't check for updates in _initInstallerApp #592

Merged
merged 1 commit into from Apr 5, 2024

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Apr 5, 2024

This is a follow-up to #589, also concerning the delay during subiquity's startup.
As Olivier pointed out here, we're currently checking for snap updates before launching the installer wizard. If there's no network connection at this point, the blocking call takes 30 seconds to time out.
I think the simplest solution is to remove that call from there entirely, as it is done later on anyways.

Even though the refresh page is shown after the network page, the user could still choose not to connect to the internet, so I added a connectivity check to the refresh page's load() function - skipping it in case there's no connection.

@d-loose d-loose marked this pull request as ready for review April 5, 2024 13:12
@d-loose
Copy link
Member Author

d-loose commented Apr 5, 2024

Even though the refresh page is shown after the network page, the user could still choose not to connect to the internet, so I added a connectivity check to the refresh page's load() function - skipping it in case there's no connection.

I'm realizing this is a bit tricky, since it makes the integration tests depend on the network connectivity of the host. I think it's ok to remove that bit again. The user can't get stuck on the refresh page, as they can just press 'skip' if the check is taking too long (due to any kind of network troubles). Also, the following page is the autoinstall page, which relies on a network connection as well. I'll open a separate issue for those things.

@d-loose d-loose merged commit e2cf3ad into canonical:main Apr 5, 2024
17 checks passed
@d-loose d-loose deleted the no-refresh-on-loading branch April 5, 2024 14:02
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
feat(bootstrap): don't check for updates in `_initInstallerApp`
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
feat(bootstrap): don't check for updates in `_initInstallerApp`
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
feat(bootstrap): don't check for updates in `_initInstallerApp`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants