Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bootstrap): set input source directly #627

Merged
merged 3 commits into from Apr 11, 2024
Merged

feat(bootstrap): set input source directly #627

merged 3 commits into from Apr 11, 2024

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Apr 11, 2024

Fixes https://bugs.launchpad.net/subiquity/+bug/2060387 by directly calling gsettings from the UI instead of only relying on subiquity.

I'll address the flavor-specific issue https://bugs.launchpad.net/ubuntu-desktop-provision/+bug/2058503 in a separate PR. Will need to do some testing first and see if invoking setxkbmap is enough.

@d-loose d-loose merged commit 5b5d3cf into canonical:main Apr 11, 2024
17 checks passed
@d-loose d-loose deleted the gsettings-input-source branch April 11, 2024 11:29
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@d-loose
Merge pull request #627 from d-loose/gsettings-input-source
10c7ce0 
feat(bootstrap): set input source directly
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@d-loose
Merge pull request #627 from d-loose/gsettings-input-source
05d6101 
feat(bootstrap): set input source directly
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@d-loose
Merge pull request #627 from d-loose/gsettings-input-source
e122ead 
feat(bootstrap): set input source directly
This was referenced Apr 11, 2024
Closed
Merged
BLKKKBVSIK added a commit that referenced this pull request Apr 12, 2024
@BLKKKBVSIK
Squashed commit of the following:
1962389 
commit b36f9d5
Merge: 8bec1f4 0f868fe
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 12:43:21 2024 +0200

    Merge pull request #639 from d-loose/contributing-bug-tracker

    docs: add bugtracker link to CONTRIBUTING.md

commit 8bec1f4
Merge: e54eec3 f2f5487
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 12:43:13 2024 +0200

    Merge pull request #636 from d-loose/non-reportable-errors

    feat(bootstrap): add support for non reportable errors from subiquity

commit f2f5487
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 11:28:25 2024 +0200

    feat(ubuntu_bootstrap): add nonreportableError to tests

commit 267db29
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 11:26:07 2024 +0200

    feat(subiquity_test): add nonReportableError to fake

commit 56ec94e
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 11:25:06 2024 +0200

    feat(subiquity_client): update types

commit 0f868fe
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 12:25:06 2024 +0200

    docs: add bugtracker link to CONTRIBUTING.md

commit e54eec3
Merge: 4b926ec 45d666d
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 12:29:58 2024 +0200

    Merge pull request #637 from d-loose/update-mocks

    chore(init): update mocks

commit 45d666d
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Fri Apr 12 11:41:58 2024 +0200

    chore(init): update mocks

commit 4b926ec
Merge: e115cfc 7b4f90c
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 16:29:34 2024 +0200

    Merge pull request #632 from d-loose/xkb-input-source

    feat(bootstrap): set keyboard via setxkbmap

commit 7b4f90c
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 16:18:51 2024 +0200

    feat(bootstrap): don't await setxkbmap call

commit b866c55
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 14:54:11 2024 +0200

    feat(bootstrap): set keyboard via setxkbmap

commit e115cfc
Merge: 07eaf67 28f761f
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 16:20:23 2024 +0200

    Merge pull request #630 from canonical/renovate/packages-subiquity_client-subiquity-digest

    chore(deps): update packages/subiquity_client/subiquity digest to 6db2ff8

commit 28f761f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Apr 11 14:02:13 2024 +0000

    chore(deps): update packages/subiquity_client/subiquity digest to 6db2ff8

commit 07eaf67
Merge: 5b5d3cf 964fbc4
Author: Matthew Hagemann <93575731+matthew-hagemann@users.noreply.github.com>
Date:   Thu Apr 11 15:40:05 2024 +0200

    Merge pull request #626 from matthew-hagemann/provd-group-and-lc-managment

    fix(provd): use provd group, not gnome-initial-setup group

commit 964fbc4
Author: Matthew Hagemann <matt.hagemann@canonical.com>
Date:   Thu Apr 11 12:10:31 2024 +0200

    fix(provd): use provd group, not gnome-initial-setup group

commit 5b5d3cf
Merge: ee025ba b5fafa6
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 13:29:05 2024 +0200

    Merge pull request #627 from d-loose/gsettings-input-source

    feat(bootstrap): set input source directly

commit ee025ba
Merge: c72429f 111cdb1
Author: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Date:   Thu Apr 11 13:28:02 2024 +0200

    Merge pull request #625 from canonical/fix/flavor-name-in-slides-2

    fix: Replace {{ DISTRO }} with flavor name in slides

commit b5fafa6
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 13:02:11 2024 +0200

    test(installer_wizard): add mock gsettings

commit d7aa186
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 11:52:57 2024 +0200

    refactor: remove duplicate mocks

commit ce55002
Author: Dennis Loose <dennis.loose@canonical.com>
Date:   Thu Apr 11 11:48:49 2024 +0200

    feat(bootstrap): set input source via gsettings

commit 111cdb1
Author: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Date:   Thu Apr 11 11:52:38 2024 +0200

    chore: Replace Ubuntu with {{ DISTRO }} in slide files

commit fe5d60b
Author: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Date:   Thu Apr 11 11:52:17 2024 +0200

    fix: Replace {{ DISTRO }} with flavor name in slides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-loose @spydon