reset-tools: fixes and improvements in snapcraft.yaml #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medicalwei
force-pushed
the
reset-tools-rename-yaml-interface
branch
from
d100790
to
46a384a
Compare
spydon
approved these changes
Apr 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…face reset-tools: fixes and improvements in snapcraft.yaml
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…face reset-tools: fixes and improvements in snapcraft.yaml
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…face reset-tools: fixes and improvements in snapcraft.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR has some bugs in building snapcraft.yaml, as I forgot to remove lines that copy desktop entry (
factory-reset-tools.desktop) and icon (factory-reset-tools.png), since it is now using default path (snap/gui) for both of these files.Also, according to a comment in manual review (https://forum.snapcraft.io/t/manual-review-autoconnect-request-for-factory-reset-tools/39404/7), I am asked to change a name of system-files interface in order to fit the convention.