Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame: migrate to std::filesystem #180

Merged
merged 1 commit into from
Apr 29, 2024
Merged

frame: migrate to std::filesystem #180

merged 1 commit into from
Apr 29, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Apr 24, 2024

No description provided.

@Saviq Saviq requested a review from a team as a code owner April 24, 2024 14:36
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye boost!

@AlanGriffiths
Copy link
Contributor

Just beware: there were some subtle changes between boost and what got standardised. We need confidence that nothing was broken by these changes. (I.e. really test stuff still works)

@Saviq
Copy link
Collaborator Author

Saviq commented Apr 24, 2024

@mattkae FYI:

https://mir-server.io/docs/how-to-use-the-ubuntu-frame-diagnostic-feature

Can be tested nested just fine.

@mattkae
Copy link
Contributor

mattkae commented Apr 29, 2024

Testing

  • Pulled sudo snap install ubuntu-frame --channel edge/pr180
  • Ran WAYLAND_DISPLAY=wayland-98 ubuntu-frame
  • Ran WAYLAND_DISPLAY=wayland-98 frame-diagnostic "Hello, world!"
  • Ran WAYLAND_DISPLAY=wayland-98 frame-diagnostic "Goodbye world!"
  • Ran WAYLAND_DISPLAY=wayland-98 gedit

Everything worked as expected

@mattkae mattkae added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit b212925 Apr 29, 2024
3 checks passed
@mattkae mattkae deleted the std-filesystem branch April 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants