Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support a make target for building gadgets #117

Merged
merged 4 commits into from Mar 17, 2023

Conversation

jawn-smith
Copy link
Contributor

Leaving as a draft as no new tests have been written.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #117 (0835665) into feature/classic-image-redesign (435d899) will not change coverage.
The diff coverage is 100.00%.

@@                       Coverage Diff                        @@
##           feature/classic-image-redesign      #117   +/-   ##
================================================================
  Coverage                          100.00%   100.00%           
================================================================
  Files                                   9         9           
  Lines                                1913      1915    +2     
================================================================
+ Hits                                 1913      1915    +2     
Impacted Files Coverage Δ
internal/imagedefinition/image_definition.go 100.00% <ø> (ø)
internal/statemachine/classic_states.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jawn-smith jawn-smith marked this pull request as ready for review March 16, 2023 21:30
Copy link
Contributor

@mwhudson mwhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, don't have enough context to know if this behaviour is what users expect :)

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's as we discussed. This feels like a sane design decision. My only proposition would be to maybe use GadgetTarget instead of MakeTarget, but both names are good.

@jawn-smith jawn-smith merged commit 6019f08 into feature/classic-image-redesign Mar 17, 2023
10 of 12 checks passed
@upils upils deleted the make-target branch September 25, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants