Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-5570 - Support the keep-enabled parameter in ubuntu-image extra-ppas #150

Merged
merged 6 commits into from Oct 19, 2023

Conversation

upils
Copy link
Collaborator

@upils upils commented Oct 9, 2023

To use newly testing object this PR is rebased on https://github.com/canonical/ubuntu-image/tree/add-pack-feature.

@upils upils requested a review from sil2100 October 9, 2023 10:35
@upils upils changed the base branch from main to add-pack-feature October 9, 2023 12:00
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #150 (0e6e016) into main (73ec099) will decrease coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 95.90%.

❗ Current head 0e6e016 differs from pull request most recent head 9cca2e6. Consider uploading reports for the commit 9cca2e6 to get more accurate results

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   90.58%   90.48%   -0.10%     
==========================================
  Files          13       13              
  Lines        2516     2533      +17     
==========================================
+ Hits         2279     2292      +13     
- Misses        210      214       +4     
  Partials       27       27              
Files Coverage Δ
internal/statemachine/classic_states.go 97.31% <100.00%> (+0.03%) ⬆️
internal/statemachine/helper.go 98.67% <100.00%> (+0.01%) ⬆️
internal/statemachine/pack.go 100.00% <100.00%> (ø)
internal/statemachine/pack_states.go 100.00% <100.00%> (ø)
internal/statemachine/state_machine.go 98.00% <ø> (-0.03%) ⬇️
cmd/ubuntu-image/main.go 91.50% <97.36%> (-0.46%) ⬇️
internal/statemachine/common_states.go 99.08% <95.23%> (-0.02%) ⬇️
internal/helper/helper.go 35.58% <0.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally +1 on the changes, good test coverage. Changes themselves solid and that's the way to go. Included two small changes, but nothing too critical.

internal/helper/helper.go Outdated Show resolved Hide resolved
internal/statemachine/classic_states.go Show resolved Hide resolved
Base automatically changed from add-pack-feature to main October 19, 2023 14:56
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll bump the version and changelog and then merge (after tests finish running).

@sil2100 sil2100 merged commit d5576cb into main Oct 19, 2023
9 checks passed
@sil2100 sil2100 deleted the keep-enabled branch October 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants