New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests performance #152
Conversation
afd2b6d
to
a780e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks! I left an inline comment/question regarding the rootfs tarball case.
d15bf88
to
ccdd512
Compare
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 90.44% 90.53% +0.08%
==========================================
Files 11 11
Lines 2449 2471 +22
==========================================
+ Hits 2215 2237 +22
Misses 208 208
Partials 26 26
|
6c0449a
to
aeff22c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let's merge this.
- "git://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/" | ||
branch: jammy | ||
names: | ||
- server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if without server
here, the test would be a bit faster. Let's look into that separately.
Explore ways to improve tests performance, in particular: