Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests performance #152

Merged
merged 6 commits into from Oct 17, 2023
Merged

Improve tests performance #152

merged 6 commits into from Oct 17, 2023

Conversation

upils
Copy link
Collaborator

@upils upils commented Oct 11, 2023

Explore ways to improve tests performance, in particular:

  • reduce disk usage
  • reduce test duration

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I left an inline comment/question regarding the rootfs tarball case.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #152 (aeff22c) into main (c5f0cdc) will increase coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   90.44%   90.53%   +0.08%     
==========================================
  Files          11       11              
  Lines        2449     2471      +22     
==========================================
+ Hits         2215     2237      +22     
  Misses        208      208              
  Partials       26       26              
Files Coverage Δ
internal/statemachine/classic_states.go 97.28% <100.00%> (+0.05%) ⬆️
internal/statemachine/common_states.go 100.00% <100.00%> (ø)
internal/statemachine/helper.go 98.66% <100.00%> (+<0.01%) ⬆️
internal/statemachine/state_machine.go 98.03% <100.00%> (+0.03%) ⬆️

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's merge this.

- "git://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/"
branch: jammy
names:
- server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if without server here, the test would be a bit faster. Let's look into that separately.

@sil2100 sil2100 merged commit 4dfac03 into main Oct 17, 2023
10 of 12 checks passed
@sil2100 sil2100 deleted the test-disk-usage branch October 17, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants