Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-5713 - Clean image build leftovers #155

Merged
merged 10 commits into from Oct 19, 2023
Merged

Conversation

upils
Copy link
Collaborator

@upils upils commented Oct 16, 2023

No description provided.

@upils upils force-pushed the clean-image-build-leftovers branch from 84d1fb8 to dfe68fd Compare October 17, 2023 09:59
@upils upils force-pushed the clean-image-build-leftovers branch from dfe68fd to 1d3f5a9 Compare October 17, 2023 10:20
@upils upils marked this pull request as ready for review October 17, 2023 12:04
@upils upils requested a review from sil2100 October 17, 2023 12:04
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #155 (84a2e75) into main (aeff22c) will decrease coverage by 0.28%.
Report is 1 commits behind head on main.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   90.53%   90.25%   -0.28%     
==========================================
  Files          11       11              
  Lines        2471     2505      +34     
==========================================
+ Hits         2237     2261      +24     
- Misses        208      213       +5     
- Partials       26       31       +5     
Files Coverage Δ
internal/statemachine/state_machine.go 98.03% <ø> (ø)
internal/statemachine/classic_states.go 96.20% <70.58%> (-1.08%) ⬇️

Copy link
Member

@waveform80 waveform80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane to me, and many thanks for picking up on the debconf/dpkg clean-up. Checked the Pi images again, and those *-old files are indeed present so this is certainly still needed too.

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of having a separate state for this, very clean. LGTM.

@sil2100 sil2100 merged commit cb08c38 into main Oct 19, 2023
5 of 9 checks passed
@sil2100 sil2100 deleted the clean-image-build-leftovers branch October 19, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants