FR-5720 - Use eatmydata #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 90.61% 90.62% +0.01%
==========================================
Files 13 13
Lines 2633 2636 +3
==========================================
+ Hits 2386 2389 +3
Misses 215 215
Partials 32 32
|
|
@sil2100 Do no worry about failing tests, this is due to a bad rebase I did in a previous PR. This is fixed in #143 that is expected to be merged first. As I already mentioned I was unable to find a use case where eatmydata is reducing the build time (tried various image definition, on various machines). If you have a usecase in mind let me know. |
sil2100
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.