Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ubuntu-image.rst to Ubuntu Install Guide #193

Merged
merged 1 commit into from Mar 13, 2024

Conversation

rkratky
Copy link
Contributor

@rkratky rkratky commented Mar 7, 2024

This PR removes the ubuntu-image.rst file (the former man page) because it was moved to be published as a reference page in the Ubuntu Installation Guide.

See canonical/subiquity#1929 for details (do not merge this PR until the linked one is merged -- only then the new link will become available).

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (1313d05) to head (63f75d8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   87.33%   77.55%   -9.78%     
==========================================
  Files          15       15              
  Lines        3915     3921       +6     
==========================================
- Hits         3419     3041     -378     
- Misses        436      814     +378     
- Partials       60       66       +6     
Flag Coverage Δ
unittests 77.55% <ø> (-9.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@upils upils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do not worry about the dependencies vuln check failing, this is unrelated and will be fixed in another PR.

README.md Outdated Show resolved Hide resolved
@upils
Copy link
Collaborator

upils commented Mar 7, 2024

I think you should also remove this check https://github.com/canonical/ubuntu-image/blob/main/.github/workflows/documentation.yml#L51 and the next one, that will not make sense anymore.

@rkratky
Copy link
Contributor Author

rkratky commented Mar 13, 2024

I think you should also remove this check https://github.com/canonical/ubuntu-image/blob/main/.github/workflows/documentation.yml#L51 and the next one, that will not make sense anymore.

Good point.

I have fixed the link and removed the two checks.

@upils upils merged commit db3d010 into canonical:main Mar 13, 2024
9 of 12 checks passed
@rkratky rkratky deleted the FR-6783_reference-to-rtd branch March 14, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants