Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of system-data partitions #26

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Fix naming of system-data partitions #26

merged 2 commits into from
Nov 18, 2021

Conversation

jawn-smith
Copy link
Contributor

This was causing an issue with expanding the filesystems on some core images.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #26 (4b4879d) into main (10b654d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          979       984    +5     
=========================================
+ Hits           979       984    +5     
Impacted Files Coverage Δ
internal/statemachine/helper.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b654d...4b4879d. Read the comment docs.

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I remember this part from the Python part indeed. There was much code to rewrite so it doesn't surprise me that we missed something! Thanks for catching it.

@sil2100 sil2100 merged commit 137514f into main Nov 18, 2021
@jawn-smith jawn-smith deleted the system-data-part-name branch May 18, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants