New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve home page #25
Conversation
* Move the community engagement details from reference topic to home page and delete the reference topic. * Make minor improvements to structure of home page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM :) although I think some of the questions you raised are probably better answered by the others, it's an undeniable improvement.
Do we want to include the traditional "line breaking at 79 characters" policy that I've seen elsewhere, or is it not needed here?
docs/index.rst
Outdated
article<communication>` and you will find out how to most easily get in | ||
touch with other developers. | ||
The Ubuntu Packaging Guide is an open source project that warmly welcomes | ||
community projects, contributions, suggestions, fixes and constructive feedback. Read our `Code of Conduct`_ to get started. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to specifically call out the code of conduct/draw attention to it by separating it off: I prefer it as a bullet point (although I'm not sure it would make sense here with only one bullet point!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current reformat, a separate bullet point does not make sense but I did make it the beginning of a paragraph to garner more attention, WDYT?
docs/index.rst
Outdated
* #ubuntu-devel (for general development discussion) | ||
* #ubuntu-motu (for MOTU team discussion and generally getting help) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These channels do still exist and are still used. I'm not sure if there are any other channels that should be included - or any that the Community team would like us to add. Could be worth checking with Aaron?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: The problem is that it depends on what you want to do in Ubuntu. Recommending those two in general seems fine to me.
issue: We have to explain to beginners what "MOTU" (Masters of the Universe, see https://wiki.ubuntu.com/MOTU) is.
thought: I thought of adding a glossary (https://sublime-and-sphinx-guide.readthedocs.io/en/latest/glossary.html) for terms like MOTU, FTBFS, NBS, ... that show up frequently in Ubuntu communication. Maybe we should even add a small glossary for slang abbreviations like ACK, IIRC, AFAICT, ... Because they confused the heck out of me when I started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glossary is a good idea. For now, I have included the link and the expanded form of MOTU.
@@ -107,23 +117,19 @@ community projects, contributions, suggestions, fixes and constructive feedback. | |||
contribute.rst | |||
|
|||
Further reading | |||
=============== | |||
--------------- | |||
|
|||
You can read this guide offline in different formats, if you install one of | |||
the `binary packages <BinPkgs_>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will probably want to update the source of this link, since this still points to Launchpad. Although the Launchpad version will still be there - Dave or Dominik can probably confirm which is the best to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: @waveform80 is currently working on this, but I think the link will not change. The current binary package is just outdated.
I tried checking on this and there's line breaking at 79 and then at 119 characters. Which one do we want to follow? I checked some files but not sure if this has been followed consistently with all files. Maybe worth checking in the meeting tomorrow? |
Good idea - I don't think it was followed consistently before, but if we're re-writing everything from scratch it's the perfect time to decide what style we want to follow 🙃 |
As just discussed in the meeting, I opened a Pull Request to update & extend the Communication Channel References. |
praise: I really like what you did here. Also +1 on adding the pre-commit checks. |
thought: I would like to have a formatting policy like:
|
note: before I delete my notes on Ubuntu communication; here is the remaining stuff that I did not put into keirthana#1 Maybe you find it useful or want to partially include it:
|
Update Community & Communication Channel References
I have added this since it seems like something that will help a beginner.
I have included a tip in general and followed it up with the bug mailing list example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. Thanks for all your work on this :)
The only thing I wanted to ask about (although it's not a blocker to merging) is about the change to the header markers. The original order used (##, ==, --) is from the general Python documentation style guide. I know you've been working on the style guide stuff, so if you've managed to dig up a better convention for us to follow in your sleuthing, would you mind writing up a style guide page for anyone who wants to contribute specifically to the docs? (again, doesn't need to be in this PR, but would be really great to have :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keirthana You can go ahead and merge if you want. I have one last Nitpick, but that is just a preference on my side.
Praise: Thanks for your effort :)
docs/index.rst
Outdated
any of the `IRC channels`_. You may find especially these channels useful in the beginning: | ||
|
||
* ``#ubuntu-devel``, for general development discussion | ||
* ``#ubuntu-motu``, for `Masters of the Universe`_ (MOTU) team discussion and generally getting help. | ||
* ``#ubuntu-meeting``, for discussions on Ubuntu and related topics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last Nitpick; I think the description for #ubuntu-meeting is more accurate this way, but this is just my preference:
any of the `IRC channels`_. You may find especially these channels useful in the beginning: | |
* ``#ubuntu-devel``, for general development discussion | |
* ``#ubuntu-motu``, for `Masters of the Universe`_ (MOTU) team discussion and generally getting help. | |
* ``#ubuntu-meeting``, for discussions on Ubuntu and related topics. | |
any of the `IRC channels`_. You may find especially these channels useful or interesting in the beginning: | |
* ``#ubuntu-devel``, for general development discussion | |
* ``#ubuntu-motu``, for `Masters of the Universe`_ (MOTU) team discussion and generally getting help | |
* ``#ubuntu-meeting``, meetings are held here by various Ubuntu teams (everyone is welcome to participate) |
Note: In the future, I also want to replace the MOTU term explanation by a reference to the (not yet existing) glossary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I will make this change and merge it. And yes, agree on moving common terminology to the Glossary later on.
I followed the reStructuredText style guide here, I am not sure if there is a standard one we follow. This is kinda my first experiment with reStructuredText. We should definitely discuss and decide on a style guide that we are going to follow - Canonical's or something else? Canonical's can be minimal considering the scope and scale of this guide but also could be a good place to start with. |
@dviererbe This is a first attempt at redoing the home page to align better with our documentation practice. There are some pending points to be considered:
Also, a request to add the
.pre-commit-config.yaml
to theoverhaul
branch so that the pre-commit checks can be run.