Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Logging the Landscape configuration #635

Closed
2 tasks done
iosifache opened this issue Mar 1, 2024 · 0 comments · Fixed by #681
Closed
2 tasks done

Issue: Logging the Landscape configuration #635

iosifache opened this issue Mar 1, 2024 · 0 comments · Fixed by #681
Assignees
Labels
bug Something isn't working jira Sync to jira

Comments

@iosifache
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and found none that matched mine

Describe the issue

The overrideKey method is implemented to overwrite keys from the old Landscape configuration file with a new one. This function also logs the latter.

log.Infof(ctx, "Landscape config contains key %q. Its value will be overridden with %s", key, value)

Despite no sensitive key-value pair (for example, the account-wide registration key, registration_key) is not modified through this function, it is preferable to document the function as being only useable with non-sensitive key-value combinations or to disable key-value pair logging entirely.

Steps to reproduce it

N/A

Ubuntu System information

N/A

Installed versions

v0.1.2

Additional information

As discussed with @didrocks, this issue is sufficiently clear and doesn't require system logs. Hence, it was reported directly in this repository.

Double check your logs

  • I have redacted any sensitive information from the logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira Sync to jira
Projects
None yet
2 participants