-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-2173 fix exam statuses #13988
WD-2173 fix exam statuses #13988
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13988 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 107 107
Lines 2864 2864
Branches 957 957
=======================================
Hits 2123 2123
Misses 715 715
Partials 26 26 |
] | ||
# if assessment is provisioned | ||
if assessment_id: | ||
is_in_window = (now > starts_at and now < end) or ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could maybe be a unit tested function.
I don't think I can check this branch out with my permissions level to actually test this, but all of the messages and timings sound good. So long as we have verified that it will not show "In Progress" before the exam is actually in progress, all of the messages seem intuitive to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused on
provisioned_but_not_taken = is_in_window and state in [
RESERVATION_STATES["notified"],
RESERVATION_STATES["provisioned"],
]
if (
state == RESERVATION_STATES["in_progress"]
or provisioned_but_not_taken
):
actions.extend(
[
{
"text": "Continue exam"
if state
== RESERVATION_STATES["in_progress"]
else "Take exam",
"href": "/credentials/exam?"
f"id={assessment_id}",
"button_class": "p-button--positive",
}
]
)
But I think I see what's happening now.
Done
credentials/your-exams
QA
./run serve
ordotrun
credentials/your-exams
Issue / Card
Fixes 12173
Help
QA steps - Commit guidelines