Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-cloud build #10570

Merged
merged 8 commits into from
Oct 15, 2021
Merged

Multi-cloud build #10570

merged 8 commits into from
Oct 15, 2021

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Oct 7, 2021

Done

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: https://ubuntu-com-10570.demos.haus/telco/osm/multi-cloud
  • Check against above copy doc and design and ensure all is correct
  • Test buttons to make sure everything is working as expected

Issue / Card

Fixes #10501

Screenshots

Screenshot 2021-10-07 at 18 30 39

@webteam-app
Copy link

Demo starting at https://ubuntu-com-10570.demos.haus

@WajeehaHamid
Copy link

Hi
Can we have these three headings "public cloud support", "private cloud support" and "SDN assist" one after the one instead besides each other?

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions in the page, could you also update you editor to 2 spaces and run reindent please

templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
templates/telco/osm/multi-cloud.html Outdated Show resolved Hide resolved
@mtruj013
Copy link
Contributor Author

Hi Can we have these three headings "public cloud support", "private cloud support" and "SDN assist" one after the one instead besides each other?

@spencerbygraves Hi, please lmk how you'd like me to move forward with this style-wise. Should I just house each of these in their own rows keeping the p-strip--light backdrop?

@mtruj013 mtruj013 changed the title Multi-cloud build WIP Multi-cloud build Oct 12, 2021
@SirSamTumless
Copy link
Contributor

Hi Can we have these three headings "public cloud support", "private cloud support" and "SDN assist" one after the one instead besides each other?

@WajeehaHamid Why? We've had this page designed so it matches our other pages and creates a nice content flow?

@spencerbygraves
Copy link

please lmk how you'd like me to move forward with this style-wise

@mtruj013 I would leave as is unless there's a particular reason to change it. Could we also use the dark background from the design in the resources section please. You can see an example here.

Thanks.

@mtruj013
Copy link
Contributor Author

mtruj013 commented Oct 13, 2021

Could we also use the dark background from the design in the resources section please.

@spencerbygraves Sure thing, I changed it back. Have a look when you can please!

@mtruj013 mtruj013 changed the title WIP Multi-cloud build Multi-cloud build Oct 14, 2021
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the updates

@mtruj013 mtruj013 merged commit a05f727 into canonical:master Oct 15, 2021
@mtruj013 mtruj013 deleted the multi-cloud-build branch October 15, 2021 10:43
@WajeehaHamid
Copy link

that's fine. thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[/telco/osm/multi-cloud] page build
6 participants