Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send additional data to marketo on checkout page #12884

Merged
merged 4 commits into from
May 23, 2023

Conversation

minkyngkm
Copy link
Contributor

@minkyngkm minkyngkm commented May 19, 2023

Done

  • Send additional data to marketo on checkout page

QA

  • Go to demo https://ubuntu-com-12884.demos.haus/pro/subscribe
  • Buy products
  • Check your info is in the list on marketo
  • Check request body here for marketo api if needed.
  • FYI : if name has first name+ last name, it goes to first name field and last name field each,
    if it has middle name or it's single name, it all goes to last name

Issue / Card

Fixes #https://warthogs.atlassian.net/jira/software/c/projects/WD/boards/801?modal=detail&selectedIssue=WD-3834

Screenshots

Before fix:
image
After fix:
image

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-12884.demos.haus

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #12884 (260ba32) into main (c9e09f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12884   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files         105      105           
  Lines        2755     2755           
  Branches      845      845           
=======================================
  Hits         2033     2033           
  Misses        692      692           
  Partials       30       30           

Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@minkyngkm minkyngkm merged commit f61d5cf into canonical:main May 23, 2023
13 checks passed
@minkyngkm minkyngkm deleted the checkout-marketo branch May 23, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants