Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-4878 - Clickable diagram on the Nvidia page #13014

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

anthonydillon
Copy link
Contributor

Done

  • Added a link around the image as requested in the copy doc

QA

  • Open the demo
  • Go to /nvidia
  • Scroll to the "Turnkey AI solutions for the enterprise powered by Canonical and NVIDIA" and check the image is clickable as requested in the copydoc
  • Check for a11y issues

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-4878

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #13014 (f6fa896) into main (cd9ae02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13014   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         104      104           
  Lines        2774     2774           
  Branches      869      869           
=======================================
  Hits         2075     2075           
  Misses        677      677           
  Partials       22       22           

@albertkol
Copy link
Contributor

Demo link: https://ubuntu-com-13014.demos.haus/

@albertkol albertkol self-assigned this Jul 5, 2023
Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Blissful!

@albertkol
Copy link
Contributor

I am not sure what A11y checks need to be done, but code and QA is fine.

@anthonydillon
Copy link
Contributor Author

I have confirmed we have no a11y errors via Wave:
image

@anthonydillon anthonydillon merged commit 5942bb7 into canonical:main Jul 5, 2023
16 checks passed
@anthonydillon anthonydillon deleted the WD-4878 branch July 5, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants