Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sitemaps and fix robots.txt path for analytics #13043

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Jul 18, 2023

Done

  • Moved robots.txt to root folder
  • Generate sitemaps for engage pages.

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-5037?atlOrigin=eyJpIjoiOWVjYjBiZjcyYzlhNDRjODkzZGVjOGU1ZTZlYzg5ZTQiLCJwIjoiaiJ9

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13043.demos.haus

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #13043 (eba196d) into main (76281b1) will not change coverage.
The diff coverage is n/a.

❗ Current head eba196d differs from pull request most recent head 8a9406e. Consider uploading reports for the commit 8a9406e to get more accurate results

@@           Coverage Diff           @@
##             main   #13043   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         107      107           
  Lines        2873     2873           
  Branches      928      928           
=======================================
  Hits         2152     2152           
  Misses        699      699           
  Partials       22       22           

@carkod carkod changed the title WIP Generate sitemaps and fix robots.txt path for analytics Generate sitemaps and fix robots.txt path for analytics Jul 19, 2023
@carkod carkod requested a review from albertkol July 19, 2023 13:32
@carkod
Copy link
Contributor Author

carkod commented Jul 20, 2023

Reviewed by @caldav

@carkod carkod assigned albertkol and mtruj013 and unassigned albertkol Jul 20, 2023
@carkod carkod removed the request for review from albertkol July 24, 2023 08:44
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carkod carkod merged commit a3894cb into canonical:main Jul 24, 2023
13 checks passed
@carkod carkod deleted the move-robots-wd-5011 branch July 24, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants