-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /certified paths to favor pretty links #13051
Conversation
Demo starting at https://ubuntu-com-13051.demos.haus |
Codecov Report
@@ Coverage Diff @@
## main #13051 +/- ##
==========================================
- Coverage 74.90% 74.80% -0.11%
==========================================
Files 107 107
Lines 2873 2881 +8
Branches 928 936 +8
==========================================
+ Hits 2152 2155 +3
- Misses 699 704 +5
Partials 22 22 |
aa119b5
to
201c594
Compare
This throws a 404. I have also noticed when more than one filter is selected, only one is preserved during the redirection. E.g. https://ubuntu-com-13051.demos.haus/certified?q=&category=Device&vendor=AAEON+Technology+Inc.&vendor=ADLink+Technology%2C+Inc. redirects to https://ubuntu-com-13051.demos.haus/certified/iot?q=&vendor=AAEON+Technology+Inc., dropping the second vendor filter. This also happens with the release filter. Can you address this? |
0e17066
to
5e3dea3
Compare
|
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Redirect search ?category=<category-name> to /<category-name> except when multiple categories are selected.
5e3dea3
to
cef07c2
Compare
Done
At the moment https://ubuntu.com/certified?q=&category=Desktop and Certified desktops | Ubuntu look different. They shouldn’t. The former (the regular search page) should redirect to the latter (the category page).
Pretty URLs should take precedence, so queries like https://ubuntu.com/certified?q=Nvidia&category=Desktop should be redirected to https://ubuntu.com/certified/desktops?q=Nvidia (URL should remain unchanged when more than one category is selected)
When there is more than one category selected, URL structure should remain unchanged: https://ubuntu.com/certified?q=Nvidia&category=Desktop&category=Laptops
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-4665?atlOrigin=eyJpIjoiMDhiYTUyZDkwYWI0NGQxZWJkOTA1MWRlMWVjYTk3YTMiLCJwIjoiaiJ9
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines